Skip to content

fix: Fixed division by 0 #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

fix: Fixed division by 0 #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions headlessmc-lwjgl/src/main/java/io/github/headlesshq/headlessmc/lwjgl/LwjglProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ public interface LwjglProperties {
String REFRESH_RATE = "hmc.lwjgl.refreshrate";
String BITS_PER_PIXEL = "hmc.lwjgl.bitsperpixel";
String JNI_VERSION = "hmc.lwjgl.nativejniversion";
String UNIFORM_OFFSET_ALIGNMENT = "hmc.lwjgl.uniformoffsetalignment";
String NO_AWT = "hmc.lwjgl.no.awt";

String TWEAKER_MAIN_CLASS = "hmc.tweaker.main.class";
Expand Down
17 changes: 17 additions & 0 deletions ...l/src/main/java/io/github/headlesshq/headlessmc/lwjgl/redirections/LwjglRedirections.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
public class LwjglRedirections {
public static final int GL_TEXTURE_WIDTH = 4096;
public static final int GL_TEXTURE_INTERNAL_FORMAT_CONST = 4099;
public static final int GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT = 0x8A34;

public static final int GL_TEXTURE_INTERNAL_FORMAT = Integer.parseInt(
System.getProperty(LwjglProperties.GL_TEXTURE_INTERNAL_FORMAT, "32856")); //RGBA8
public static final int TEXTURE_SIZE = Integer.parseInt(
Expand All @@ -33,6 +35,8 @@ public class LwjglRedirections {
System.getProperty(LwjglProperties.BITS_PER_PIXEL, "32"));
public static final int JNI_VERSION = Integer.parseInt(
System.getProperty(LwjglProperties.JNI_VERSION, "24"));
public static final int UNIFORM_OFFSET_ALIGNMENT = Integer.parseInt(
System.getProperty(LwjglProperties.UNIFORM_OFFSET_ALIGNMENT, "1"));
private static final ThreadLocal<Long> CURRENT_BUFFER_SIZE =
ThreadLocal.withInitial(() -> 0L);
private static final long START = System.nanoTime();
Expand Down Expand Up @@ -315,6 +319,19 @@ public static void register(RedirectionManager manager) {
//j net.caffeinemc.mods.sodium.api.memory.MemoryIntrinsics.copyMemory(JJI)V+8
//j net.minecraft.class_287.push(Lorg/lwjgl/system/MemoryStack;JILnet/caffeinemc/mods/sodium/api/vertex/format/VertexFormatDescription;)V+47
//j me.jellysquid.mods.sodium.client.render.vertex.buffer.SodiumBufferBuilder.push(Lorg/lwjgl/system/MemoryStack;JILnet/caffeinemc/mods/sodium/api/vertex/format

// 1.21.6 onwards
// DynamicUniformStorage.<init>
// GlDevice this.uniformOffsetAlignment = GL11.glGetInteger(35380);
// division by zero, because the integer returned is 0
manager.redirect("Lorg/lwjgl/opengl/GL11;glGetInteger(I)I",
(obj, desc, type, args) -> {
if ((int) args[0] == GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT) {
return UNIFORM_OFFSET_ALIGNMENT;
}

return 0;
});
}

}
Loading