DOC-606: update artifacts to latest #1895
Conversation
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| <dependencies> | ||
| <dependency> | ||
| <groupId>com.hazelcast.jet</groupId> | ||
| <artifactId>hazelcast-jet</artifactId> |
There was a problem hiding this comment.
jet is now part of main distribution
There was a problem hiding this comment.
sorry @k-jamroz I don't understand what this means in terms of the changes required to the doc. Can you please markup what, if anything, needs to be updated on lines 49-52, plus advise what we should say about mvn clean install as per Authors Note above. Thanks
There was a problem hiding this comment.
there is no hazelcast-jet artifact (JAR) anymore. everything is contained in hazelcast and hazelcast-enterprise
There was a problem hiding this comment.
see https://github.com/hazelcast/hz-docs/pull/1895/files#r2411354148, if there are other references to hazelcast-jet artifacts they should also be changed
There was a problem hiding this comment.
but the extensions, like hazelcast-jet-kafka etc. still exist as sepearate modules
| <groupId>com.hazelcast.jet</groupId> | ||
| <artifactId>hazelcast-jet</artifactId> |
There was a problem hiding this comment.
| <groupId>com.hazelcast.jet</groupId> | |
| <artifactId>hazelcast-jet</artifactId> | |
| <groupId>com.hazelcast</groupId> | |
| <artifactId>hazelcast</artifactId> |
| into it: | ||
| `trade-monitor` and copy the Maven file into it: | ||
|
|
||
| // AUTHORS NOTE: if we are to tell them to use mvn clean install to build the project, where |
There was a problem hiding this comment.
there are 2 different builds:
- you need to build hazelcast-code-samples/ project
- the example project in this tutorial uses some JAR created by hazelcast-code-samples/ project but is a separate project
the workflow should be roughly (this will build all examples, not only jet-related):
git clone https://github.com/hazelcast/hazelcast-code-samples.git
cd hazelcast-code-samples
mvn clean install
this should be performed in "Before You Begin" section
then you create java project etc. and step 3 (mvn clean package) remains the same.
Note that I have not tested these commands - worth checking for typos or if I missed sth.
For https://hazelcast.atlassian.net/browse/DOC-606
Apply same changes to windowing.adoc as per #580 (#1883) which corrected the artifacts for the samples so these point to the correct versions. Affects lines 57 & 58 in windowing.adoc
@k-jamroz Please also take a look at the authors question on line 32:
// AUTHORS NOTE: if we are to tell them to use mvn clean install to build the project, where
// should this go? Here or later in the process, such as line 203 instead of mvn package?
// For example "Run mvn clean install to make sure you can build the project and get its artifacts locally."
// Does that sound OK? If so, I will apply the same chnage in the map-join.adoc file which is similar.
Please advise