Change level of the log for unrecognized events to fine DEX-439 #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with the Java client. See client protocol [PR](hazelcast/hazelcast-client-protocol#551) Re-generated and updated codecs. This required introduction of the new class `version` for cluster version.
ihsandemir
changed the title
ihsandemir
changed the title
JackPGreen
reviewed
May 27, 2025
Comment on lines
+61
to
+76
| /* | ||
| bool operator==(const version& rhs) const; | ||
|
|
||
| bool operator!=(const version& rhs) const; | ||
|
|
||
| bool operator<(const version& rhs) const; | ||
|
|
||
| bool operator>(const version& rhs) const; | ||
|
|
||
| bool operator<=(const version& rhs) const; | ||
|
|
||
| bool operator>=(const version& rhs) const; | ||
|
|
||
| friend std::ostream HAZELCAST_API& operator<<(std::ostream& os, | ||
| const version& version); | ||
| */ |
There was a problem hiding this comment.
Why are we adding newly-commented out code?
There was a problem hiding this comment.
forgot to mention PR is still draft. let mw change the status. i will complete this part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the level of the log for unrecognized events to fine in sync with the Java client.
See client protocol PR
Re-generated and updated codecs. This required introduction of the new class
versionfor cluster version.fixes #1293