metadata storage abstraction for scheduled triggers #6131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakeshkky
added
c/server
abooij
reviewed
Nov 4, 2020
lexi-lambda
reviewed
Nov 6, 2020
abooij
reviewed
Nov 6, 2020
Co-authored-by: Auke Booij <[email protected]>
|
Deploy preview for hasura-docs ready! Built with commit efbca69 |
This partially reverts commit efbca69. The reviewer's suggestion did not work out
|
Deploy preview for hasura-docs ready! Built with commit 7227d54 |
abooij
reviewed
Nov 9, 2020
rakeshkky
force-pushed
the
5797-scheduled-triggers-abstraction
branch
from
add6ad7 to
2b25700
Compare
rakeshkky
force-pushed
the
5797-scheduled-triggers-abstraction
branch
from
2b25700 to
37db141
Compare
Resolve Conflicts: server/src-lib/Hasura/Backends/Postgres/SQL/DML.hs
Contributor
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
-> Each method in the aforementioned type class is executed in a separate transaction. Using specific function `runInSeparateTx` instead of `liftTx` is reasonable.
abooij
reviewed
Nov 11, 2020
Co-authored-by: Auke Booij <[email protected]>
abooij
approved these changes
Nov 11, 2020
Contributor
abooij
left a comment
abooij
left a comment
There was a problem hiding this comment.
Approving this PR to unblock further work, despite ongoing discussions that we may wish to return to at a later stage.
lexi-lambda
reviewed
Nov 19, 2020
Contributor
lexi-lambda
left a comment
lexi-lambda
left a comment
There was a problem hiding this comment.
After my conversation last night with @rakeshkky, I understand the issues at play here much better. I’ve left a suggestion to reword the comment to be more explicit about exactly what’s going on, but otherwise I’m happy with this PR as it stands
Co-authored-by: Alexis King <[email protected]>
Contributor
|
Thanks for your contribution! Your changes have been merged successfully. |
hasura-bot
added a commit
that referenced
this pull request
Nov 25, 2020
An incremental PR towards #5797 * metadata storage abstraction for scheduled triggers Co-authored-by: rakeshkky <[email protected]> Co-authored-by: Rakesh Emmadi <[email protected]> Co-authored-by: Auke Booij <[email protected]> GITHUB_PR_NUMBER: 6131 GITHUB_PR_URL: #6131 * update pro server code Co-authored-by: rakeshkky <[email protected]> Co-authored-by: Auke Booij <[email protected]> GitOrigin-RevId: 17244a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an incremental PR towards #5797. It introduces an abstraction for metadata storage
MonadMetadataStorageso that the caller of the functionrunHGEServercan customize the implementations via type class instance. It is a step towards separation of metadata from users database. This PR ONLY abstracted the operations related to scheduled triggers eventing sub-system. Subsequent PRs will contain operations related to metadata management and async actions sub system.This also includes moving of types related to scheduled triggers.
To Reviewers: Feel free to post your thoughts on type class design and suggest improvements 😅
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.Affected components
Related Issues
Solution and Design
Each function in the new type class operates in
MetadataStorageT m amonad transformer wheremis base App monad in which the functionrunHGEServeroperates in.Steps to test and verify
Limitations, known bugs & workarounds
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
GraphQL
Breaking changes