Changed task status calculation to backend #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates task status and agent count calculations from the frontend to the backend. The backend now provides status and activeAgents fields directly in the task model, eliminating the need for frontend chunk data processing and calculations.
Key Changes:
- Added
statusandactiveAgentsfields to theJTaskinterface to receive backend-calculated values - Removed frontend chunk data fetching and processing logic from the tasks datasource
- Simplified task table rendering by using backend-provided values instead of calculating from chunk data
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/app/core/_models/task.model.ts | Added activeAgents and status fields to JTask interface |
| src/app/core/_datasources/tasks.datasource.ts | Removed chunk data fetching logic and related imports |
| src/app/core/_components/tables/tasks-table/tasks-table.component.ts | Replaced calculated status/agent values with backend-provided fields and removed helper methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/app/core/_components/tables/tasks-table/tasks-table.component.ts
Outdated
Show resolved
Hide resolved
src/app/core/_components/tables/tasks-table/tasks-table.component.ts
Outdated
Show resolved
Hide resolved
gluafamichl
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reliant on pull request #1716. PLease make sure that is merged first before merging this