feat: asciidoctor-diagram support #194
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds metadata handling to the asciidoctor task. The asciidoctor task will now: 1. read asciidoctor attributes and add them as metadata 2. expose metadata to the asciidoctor process as attributes Both processes are executed independently from each other.
Enables `asciidoctor-diagram` support for generating images as defined inline in the source file. The resulting images are captured afterwards in a new task named `collect-images`, to stick to the basic content-task structure for the base asciidoctor task. Previous code was refactored to have stronger defaults for options and metadata handling.
Closed
|
I hope somebody will take a look at this PR, as it feels like a significant milestone to me. |
|
Hi Nico! Sorry for the slow responses lately. I'm trying to ramp back up on Perun after an unplanned break due to starting a new job. I'd like to get a handle on your asciidoctor PR's so that we can get them merged, but I'm a bit confused on where I should start to get an overall idea of what's going on. Can you point me in a direction? |
|
Hi, @nicorikken! |
allentiak
suggested changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables
asciidoctor-diagramsupport for generating images as defined inline in the source file. The resulting images are captured afterwards in a new task namedcollect-images, to stick to the basic content-task structure for the base asciidoctor task.Previous code was refactored to have stronger defaults for options and metadata handling.
Based on the previous PR's #191 and #193
I'm very interested to hear your comments on this work:
collect-imagestask the right way to collect images after thecontent-taskfunction?asciidoctor*now has a global switch ondiagramto determine whether or notasciidoctor-diagramis enabled. Is this correct?permalinktask so the relative URL remains the same? Another way would be to fix this upfront, by giving each post it's own directory or by changing the relative URL namedimagesdirin asciidoctor terminology.At the moment of writing you can observe the potential output at http://site.nicorikken.eu/posts/2017-08-14-testpost.html which is based on the source https://github.com/nicorikken/nicorikken.github.io/tree/perun which uses the code of this PR.