-
Notifications
You must be signed in to change notification settings - Fork 38
Fix #63 - Paginate #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #63 - Paginate #141
Conversation
Also, make arguments a map, to match other pre-wraps
|
I should have mentioned - there is one backwards-incompatible change to |
podviaznikov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me.
Only one ask would be to add use of assortment and paginate tasks into the example project https://github.com/hashobject/perun/tree/master/examples/blog
Certainly. I should have some time later today to do this for each of the open PR's. |
|
ok, so 2 PRs merged and now there is a small conflict |
|
Okay, I fixed this conflict. |
Provides a
paginatetask that sorts existing entries, partitions them bypage-size, and renders an html file for each of the resulting partitions. The render function provided to the task will be called for each file to be generated a data structure in the same shape as the one provided to thecollectiontask, a map with:entry,:entriesand:metakeys.The
assortmenttask (first discussed in #109) comes along for the ride here, becausepaginateis a subset ofassortment.This will probably conflict with other pull requests that I'm submitting at the same time, but they'll be trivial for me to fix as they get merged.