Skip to content

Conversation

@bhagany
Copy link
Contributor

@bhagany bhagany commented Jan 22, 2017

Provides a paginate task that sorts existing entries, partitions them by page-size, and renders an html file for each of the resulting partitions. The render function provided to the task will be called for each file to be generated a data structure in the same shape as the one provided to the collection task, a map with :entry, :entries and :meta keys.

The assortment task (first discussed in #109) comes along for the ride here, because paginate is a subset of assortment.

This will probably conflict with other pull requests that I'm submitting at the same time, but they'll be trivial for me to fix as they get merged.

bhagany and others added 30 commits December 4, 2016 21:17
Also, make arguments a map, to match other pre-wraps
@bhagany
Copy link
Contributor Author

bhagany commented Jan 22, 2017

I should have mentioned - there is one backwards-incompatible change to collection. The groupby option has been removed, because this is covered more natrually by assortment. It can be added back in relatively easily if you prefer.

Copy link
Member

@podviaznikov podviaznikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.
Only one ask would be to add use of assortment and paginate tasks into the example project https://github.com/hashobject/perun/tree/master/examples/blog

@bhagany
Copy link
Contributor Author

bhagany commented Jan 23, 2017

Only one ask would be to add use of assortment and paginate tasks into the example project

Certainly. I should have some time later today to do this for each of the open PR's.

@podviaznikov
Copy link
Member

ok, so 2 PRs merged and now there is a small conflict

@bhagany
Copy link
Contributor Author

bhagany commented Jan 25, 2017

Okay, I fixed this conflict.

@bhagany bhagany mentioned this pull request Jan 25, 2017
@podviaznikov podviaznikov merged commit d0027b5 into hashobject:master Jan 28, 2017
@bhagany bhagany deleted the paginate branch January 28, 2017 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants