Skip to content

Conversation

TaopaiC
Copy link

@TaopaiC TaopaiC commented Sep 13, 2024

Fix encode_path whitelist to exclude '-' from encoding

Fix `encode_path` whitelist to exclude '-' from encoding
@TaopaiC TaopaiC requested a review from a team as a code owner September 13, 2024 14:23
Copy link

hashicorp-cla-app bot commented Sep 13, 2024

CLA assistant check
All committers have signed the CLA.

@ochnerd
Copy link

ochnerd commented Oct 1, 2024

@TaopaiC would you mind adding ':' to this commit too?
We use ':' in our secrets and have the same issue.

@khiav223577
Copy link

The current code escapes ~ as %7E, but should we be doing this? CGI.escape does not escape ~.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants