[draft] Fix vault_pki_secret_backend_crl_config ignoring updates of fields to their default values #2607
+33
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
util.GetAPIRequestDataWithSliceOkExists
so zero values (for exampleauto_rebuild = false
) are sent to Vaultauto_rebuild
back to false to guard against regressionsInitial issue reproduction steps
Start a Vault 1.12+ dev server and export VAULT_ADDR/VAULT_TOKEN.
Apply this Terraform config with the provider built from main:
Update the config to set
auto_rebuild = false
and rerun terraform apply.Inspect the backend:
vault read pki/config/crl
.auto_rebuild = false
auto_rebuild
remains true, showing the provider never sent the value back to Vault. This can be further inspected by logging thedata
.After the patch, step 4 reports
auto_rebuild = false
as expected, and the new acceptance-test step now asserts this behavior.Checklist
Output from acceptance testing:
Community Note
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.