-
Notifications
You must be signed in to change notification settings - Fork 580
Fix permanent diff on vault_rabbitmq_secret_backend_role
#2474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 0 out of 2 committers have signed the CLA.
Giuseppe D'Anna seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
3f2d0ce
to
dd9e8db
Compare
@AnPucel I've signed CLA but one of the message says the opposite. Is that a problem? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a permanent diff issue in the vault_rabbitmq_secret_backend_role
resource by ensuring consistent ordering of vhosts. The fix prevents unnecessary state diffs when the order of vhosts changes between Terraform operations.
- Adds deterministic sorting to vhost processing in the flatten function
- Includes a unit test to verify the sorting behavior works correctly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
vault/resource_rabbitmq_secret_backend_role.go | Modifies vhost flattening to sort keys before processing, ensuring consistent output order |
vault/resource_rabbitmq_secret_backend_role_test.go | Adds unit test to verify vhosts are returned in alphabetical order |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description
This PR fixes #952
Add sorting for vhosts after read
Add test
Relates OR Closes #952
Checklist
Output from acceptance testing:
Community Note