[DO NOT MERGE] Azure Explicit Max TTL run CI tests #2444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for configuring `explicit_max_ttl` for Azure Secrets roles. This field was released as part of Azure Secrets plugin v0.20.0, incorporated into Vault 1.18.0 and later. Note that the field is configured as an integer to align with how other resources throughout the provider handle TTL fields. Configuring it to a seconds-based integer avoids Terraform flagging drifts between the seconds returned from Vault's API and the Terraform string-based configuration.
Change introduced in #2438
Per feedback in #2438, revert the explicit_max_ttl field in the `azure_secret_backend_role` resource to a string type for internal consistency within the resource. Fix deletion acceptance test code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR of feature to run CI tests.