Skip to content

Conversation

tmanninger
Copy link
Contributor

@tmanninger tmanninger commented Dec 14, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Solves issue: #1696

Release note for CHANGELOG:

- Add new resource "vault_cert_auth_backend_config"
- Add following parameters to resource "vault_pki_secret_backend_crl_config": ocsp_disable, ocsp_expiry, auto_rebuild, auto_rebuild_grace_period, enable_delta, delta_rebuild_interval
- Add parameter "allowed_metadata_extensions" to resource "vault_cert_auth_backend_role"

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestCertAuthBackend'
ok  	github.com/hashicorp/terraform-provider-vault/vault	3.344s

make testacc TESTARGS='-run=TestPkiSecretBackendCrlConfig_basic'
ok  	github.com/hashicorp/terraform-provider-vault/vault	4.079s

make testacc TESTARGS='-run=TestAccCertAuthBackendConfig_basic'
ok  	github.com/hashicorp/terraform-provider-vault/vault	3.869s

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 14, 2022

CLA assistant check
All committers have signed the CLA.

@tmanninger tmanninger force-pushed the pki_and_cert_auth branch 2 times, most recently from 188e1c0 to 7c520fe Compare December 14, 2022 14:23
@benashz
Copy link
Collaborator

benashz commented Dec 16, 2022

Hi @tmanninger,

First off, thank you for your contribution. It looks like this PR is both extending some current resources and adding a new resource all together. We typically prefer submissions to be a bit more focused whenever possible. I can see that we have at least two PRs here. Would you mind splitting out the field additions from the vault_cert_auth_backend_config work? That will help us to better assess things.

Thanks,

Ben

@tmanninger
Copy link
Contributor Author

Hi @benashz,

i will split out the "vault_cert_auth_backend_config" next week.
Is the documentation auto-generated? Must i generate the documentation?

@tmanninger
Copy link
Contributor Author

I created 3 new Pull Requests:
#1704
#1703
#1702

@tmanninger tmanninger closed this Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants