framework: Fix MoveResourceState tests
#382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvalle
changed the title
MoveResourceState tests and update dependencies
austinvalle
changed the title
MoveResourceState tests and update dependenciesMoveResourceState tests
austinvalle
force-pushed
the
av/identity-test-fixes
branch
from
7011729 to
d5519fd
Compare
…rm-provider-corner into av/identity-test-fixes
austinvalle
commented
Sep 22, 2025
|
Commit 7cc14dc shows the tests passing with the recent framework changes in hashicorp/terraform-plugin-framework#1193 . I don't think the commit hash need to make it into the This PR is ready for review 👍🏻 |
This reverts commit 7cc14dc.
1 task
rainkwan
approved these changes
Sep 22, 2025
| return | ||
| } | ||
|
|
||
| // Unlike normal resources, this resource can't produce it's identity during read, but it's the same value |
There was a problem hiding this comment.
Nit: I understand this comment but it does feel a little like a pronoun game
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Supersedes #367, fixes for hashicorp/terraform-plugin-framework#1193
Description
The identity that is part of the
MoveResourceStatestate test was reliant on the data passing throughReadResourcewithout erroring. Earlier versions of Terraform that don't support identity were not sending this data, which resulted in theReadfor the resource returning a null identity.As of hashicorp/terraform-plugin-framework#1193, that is no longer valid. Resources must always produce an identity during
Read, typically using the state and a remote system.Since the move resource test is really just taking data from state and putting it into identity, we can just do this during
Readas well, since we have no remote system. The check for null is really just to respect that the underlying test assertions inMoveResourceState_identitywant to test the logic ofMoveResourceStateand notReadResource, but we don't want to do a "no-refresh" test step.Rollback Plan
Changes to Security Controls
No