Add acceptance tests for SDKv2 resource with no update function and write-only attributes #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBGoods
commented
Apr 24, 2025
|
|
||
| go 1.23.7 | ||
|
|
||
| replace github.com/hashicorp/terraform-plugin-sdk/v2 v2.37.0-beta.1 => github.com/BBBmau/terraform-plugin-sdk/v2 v2.24.1-0.20250421144349-aa2d9d850504 |
There was a problem hiding this comment.
Todo: Remove this line and update SDKv2 dependency once v2.25.0 releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: hashicorp/terraform-plugin-sdk#1472
Adds write-only attribute acceptance testing for resources without an update function. The SDKv2 has internal validation that verifies that resources without an update function only have top-level attributes that have either
ForceNew, orComputedenabled, to prevent attributes in the schema that can trigger a resource update. The referenced PR also addsWriteOnlyto this list as a change to a write-only attribute should never cause an update, making it safe for use with these resources.