Add Length() function to collection values
#1187
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChihweiLHBird
changed the title
Length() function to collection types
ChihweiLHBird
changed the title
Length() function to collection typesLength() function to collection values
|
Hi @rainkwan @austinvalle @stephybun, may I get some feedbacks and reviews for this change? Thanks! |
|
Any chance this may get a review? |
|
Hey @austinvalle @rainkwan @bbasata, may I get some thoughts from your team about this proposal? Thank you! |
Hi @ChihweiLHBird, Thank you for your patience. The team recently selected this pull request for triage, and a teammate will follow-up here with any feedback to get this change merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #1067
Description
Implement
Length()functions for collection values, so users can avoidlen(list.Elements())which is less clean and efficient becauseElements()allocate a new block of memory for returning a new slice.If you guys prefer
Size()or another naming, let me know and I can change it.