-
Notifications
You must be signed in to change notification settings - Fork 24
Better align MDX content and allow tables to grow past content size #2884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
π¦ Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action π€ This PR introduced no changes to the javascript bundle π |
src/components/dev-dot-content/mdx-components/mdx-code-blocks/index.tsx
Outdated
Show resolved
Hide resolved
src/components/dev-dot-content/mdx-components/mdx-tabs/index.tsx
Outdated
Show resolved
Hide resolved
| (mod) => mod.default | ||
| ) | ||
| } | ||
| strict={process.env.NODE_ENV === 'development'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This for some reason wasn't formatted through our format rules, now it uses tabs which is why it looks so strange in github.
# Conflicts: # src/pages/_app.tsx
|
This PR is stale because it has been open 20 days with no activity. It will be closed in 5 days unless you remove the |
π Relevant links
ποΈ What
--main-element-max-widthcss var which was locking the content size of MDX contentmdx-content-full-widthwhich skips over the width limitπΈ Design Screenshots
Before (with current fixed content width)
After (with new growing content width for tables)
π§ͺ Testing
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.