Skip to content

Conversation

dchyun
Copy link
Contributor

@dchyun dchyun commented Oct 8, 2025

📌 Summary

If merged, this PR would convert the showcase pages for the FormSuperSelect to gts.

Preview page

Percy Diff

  • SingleBase and MultipleBase - The "after options generic content in footer" and "after options generic content" examples were identical, so the latter was removed.
  • SingleBase and MultipleBase - Custom result count message - The custom message text matched the default text of "X total", so it was updated to be a new custom text "Custom result count: X options"
  • In order to simplify the code fragment components, if the fragment was set to have a selected value or values on load, those values are always the first one or two options. Previously some examples had the 2nd or 3rd options selected.
  • MultipleBase - List width - All MultipleBase fragments have multiple options selected by default, but previously these examples only had one selection to limit the width of the select. With two options now selected, some minor adjustments were made to the select widths.

Page issues

It was caught during this migration that for the "Complex content" examples for the SingleField and Multiple field, the items in the list are not selectable. It seems for some reason an aria-disabled is getting set on the options by ember-power-select.

This issue is present in the existing showcase, and is working as expected in a website example. This will require more research on the showcase.

🔗 External links

Jira ticket: HDS-5373


👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

Copy link

vercel bot commented Oct 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Oct 9, 2025 9:07pm
hds-website Ready Ready Preview Oct 9, 2025 9:07pm

Copy link
Contributor

@shleewhite shleewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small things! Looks great so far.

@KristinLBradley
Copy link
Contributor

RE: "It seems for some reason an aria-disabled is getting set on the options by ember-power-select."

@dchyun this is very strange but in case you didn't notice, aria-disabled is actually not being set on the last 2 options so those actually work if you click on them.

@dchyun
Copy link
Contributor Author

dchyun commented Oct 9, 2025

RE: "It seems for some reason an aria-disabled is getting set on the options by ember-power-select."

@dchyun this is very strange but in case you didn't notice, aria-disabled is actually not being set on the last 2 options so those actually work if you click on them.

@KristinLBradley yeah I think it has to do something with what options are visible when the dropdown opens. Usually the last two options are hidden and have to be scrolled into view. Still quite odd.

Copy link
Contributor

@shleewhite shleewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a ticket to investigate the aria-disabled issue? it is odd.

@dchyun
Copy link
Contributor Author

dchyun commented Oct 10, 2025

Can you make a ticket to investigate the aria-disabled issue? it is odd.

@KristinLBradley @shleewhite created a ticket for this - https://hashicorp.atlassian.net/browse/HDS-5545

@dchyun dchyun merged commit 65895e4 into main Oct 10, 2025
16 checks passed
@dchyun dchyun deleted the dchyun/super-select-gts-conversion branch October 10, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants