-
Notifications
You must be signed in to change notification settings - Fork 50
Showcase: Convert SuperSelect to gts #3289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small things! Looks great so far.
showcase/app/components/page-components/form/super-select/sub-sections/after-options.gts
Outdated
Show resolved
Hide resolved
showcase/app/components/page-components/form/super-select/sub-sections/after-options.gts
Show resolved
Hide resolved
showcase/app/components/page-components/form/super-select/sub-sections/after-options.gts
Outdated
Show resolved
Hide resolved
showcase/app/components/page-components/form/super-select/sub-sections/after-options.gts
Outdated
Show resolved
Hide resolved
showcase/app/components/page-components/form/super-select/sub-sections/after-options.gts
Outdated
Show resolved
Hide resolved
...components/page-components/form/super-select/code-fragments/with-options-generic-content.gts
Outdated
Show resolved
Hide resolved
...components/page-components/form/super-select/code-fragments/with-options-generic-content.gts
Outdated
Show resolved
Hide resolved
RE: "It seems for some reason an aria-disabled is getting set on the options by ember-power-select." @dchyun this is very strange but in case you didn't notice, |
@KristinLBradley yeah I think it has to do something with what options are visible when the dropdown opens. Usually the last two options are hidden and have to be scrolled into view. Still quite odd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make a ticket to investigate the aria-disabled issue? it is odd.
@KristinLBradley @shleewhite created a ticket for this - https://hashicorp.atlassian.net/browse/HDS-5545 |
📌 Summary
If merged, this PR would convert the showcase pages for the FormSuperSelect to gts.
Preview page
Percy Diff
Page issues
It was caught during this migration that for the "Complex content" examples for the SingleField and Multiple field, the items in the list are not selectable. It seems for some reason an
aria-disabled
is getting set on the options by ember-power-select.This issue is present in the existing showcase, and is working as expected in a website example. This will require more research on the showcase.
🔗 External links
Jira ticket: HDS-5373
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.