Showcase: convert Pagination page to gts #3283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
shleewhite
force-pushed
the
hds-5348/showcase-pagination-gts
branch
from
12ada6d to
f45b8ed
Compare
dchyun
reviewed
Oct 10, 2025
showcase/app/components/page-components/pagination/sub-sections/base-elements.gts
Show resolved
Hide resolved
showcase/app/components/page-components/pagination/code-fragments/with-numbered-and-events.gts
Show resolved
Hide resolved
| onTableSort = (sortBy: string, sortOrder: HdsTableThSortOrder) => { | ||
| this.currentSortBy = sortBy; | ||
| this.currentSortOrder = sortOrder; | ||
| // should we reset the selected page? |
There was a problem hiding this comment.
[Note] I think it makes sense to reset it, but also fine to leave it as is since that's what's been done currently.
There was a problem hiding this comment.
Yeah, I agree we should reset it. @didoo do you have thoughts? This comment was brought over from the existing pagination showcase page.
showcase/app/components/page-components/pagination/code-fragments/with-compact-and-events.gts
Show resolved
Hide resolved
showcase/app/components/page-components/pagination/code-fragments/with-compact-and-events.gts
Outdated
Show resolved
Hide resolved
showcase/app/components/page-components/pagination/code-fragments/with-compact-and-events.gts
Show resolved
Hide resolved
showcase/app/components/page-components/pagination/code-fragments/with-compact-and-routing.gts
Outdated
Show resolved
Hide resolved
|
Approved the Percy diff, as it looked all as expected 🟢 |
added 7 commits
October 10, 2025 12:51
shleewhite
force-pushed
the
hds-5348/showcase-pagination-gts
branch
from
e8ea7bf to
7fd0728
Compare
dchyun
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would convert the pagination showcase page to gts.
This page is one of the few examples where we need to keep the
controllerfile because it usesqueryParamsin 2 of the demos. An unexpected benefit of breaking up the page into sub-components means these demos are actually more in line with how consumers implement these UIs.The source of truth for the state is in the URL, the controller only contains the list of queryParams + tracked copy of the param. Then in the component, when something (like page size) changes, you transition to the same URL and update the appropriate params which causes the tracked state in the controller to change and then makes the component re-render.
Passing the controller to the sub components is the easiest way to get the current state of the query params to the appropriate place.
Note: I had to update the acceptance tests a bit to match the new query param names + ids.
🔗 External links
Jira ticket: HDS-5348
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.