Upgrade ember-stargate
#3268
Merged
Upgrade ember-stargate
#3268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hashibot-hds
added
packages/components
docs-website
hashibot-hds
removed
docs-website
aklkv
reviewed
Oct 2, 2025
| "@embroider/addon-dev": "^7.1.5", | ||
| "@eslint/js": "^9.23.0", | ||
| "@glimmer/component": "^1.1.2", | ||
| "@glimmer/component": "^2.0.0", |
There was a problem hiding this comment.
you might need to add global override for this, similar to what we have in cloud-ui https://github.com/hashicorp/cloud-ui/blob/main/package.json#L55
There was a problem hiding this comment.
We're upgrading ember-a11y-refocus in another branch. Would waiting on that to merge solve the issue?
There was a problem hiding this comment.
it might yeah as I suggested this solution to @shleewhite when we paired on that upgrade
zamoore
changed the title
ember-stargate & @glimmer/component
zamoore
force-pushed
the
main-5.0.0
branch
2 times, most recently
from
3851d8f to
5d044c7
Compare
zamoore
force-pushed
the
zamoore/hds-4936/dependency-upgrades
branch
from
beddeda to
219ec81
Compare
kmk142789
approved these changes
Oct 6, 2025
zamoore
force-pushed
the
zamoore/hds-4936/dependency-upgrades
branch
from
219ec81 to
6615eaf
Compare
zamoore
force-pushed
the
main-5.0.0
branch
3 times, most recently
from
5fc6964 to
5ef8b4f
Compare
zamoore
force-pushed
the
zamoore/hds-4936/dependency-upgrades
branch
from
6615eaf to
abab065
Compare
zamoore
changed the title
ember-stargate & @glimmer/componentember-stargate
| import { BORDER_WIDTH } from './index.ts'; | ||
| import type Owner from '@ember/owner'; | ||
|
|
||
| import type Owner from '@ember/owner'; |
There was a problem hiding this comment.
This change seems unrelated. Perhaps we should drop it?
zamoore
force-pushed
the
zamoore/hds-4936/dependency-upgrades
branch
from
abab065 to
22ad9c2
Compare
didoo
approved these changes
Oct 10, 2025
aklkv
approved these changes
Oct 10, 2025
zamoore
added a commit
that referenced
this pull request
Oct 10, 2025
5 tasks
zamoore
added a commit
that referenced
this pull request
Oct 10, 2025
zamoore
added a commit
that referenced
this pull request
Oct 13, 2025
zamoore
added a commit
that referenced
this pull request
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR will upgrade dependencies ahead of the 5.0.0 release
🛠️ Detailed description
ember-stargateto1.0.2🔗 External links
Jira ticket: HDS-4936
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.