-
Notifications
You must be signed in to change notification settings - Fork 50
[WIP-03] [Project Solar / Phase 1 / Themed CSS for HDS components] Rollup configuration and Sass processing for multiple files #3259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
didoo
wants to merge
9
commits into
project-solar/phase-1/HDS-5216_modes/modes-pipeline-implementation
Choose a base branch
from
project-solar/phase-1/HDS-5505_components/modes-css-compilation
base: project-solar/phase-1/HDS-5216_modes/modes-pipeline-implementation
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
28fa9d6
Draft a custom plugin to compile the themed SCSS
alex-ju 68deebe
updated SCSS files organization for components (split common part) + …
didoo 8c888e4
added support for source maps for generated themed CSS files
didoo 58ee21d
TEMP - Added generation of “alt” CSS for HDS components to compare wi…
didoo 6c613d0
abstracted logic for custom Rollup plugin to compile multiple Sass fi…
didoo 414e7b2
updated `includePaths` for design tokens in Showcase and Website `emb…
didoo 8a4461a
moved compilation of existing Scss files for components and overrides…
didoo b6c7f1d
removed `rollup-plugin-scss` dev dependency (we use our own custom pl…
didoo b078d30
added CSS compilation for `combined-strategies` tokens
didoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
...ents/src/styles/@hashicorp/design-system-components-theming-with-combined-strategies.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| /** | ||
| * Copyright (c) HashiCorp, Inc. | ||
| * SPDX-License-Identifier: MPL-2.0 | ||
| */ | ||
|
|
||
| // these files come from `packages/tokens/dist/` | ||
| @use "products/css/themed-tokens/with-combined-strategies/tokens.css"; | ||
| // TODO understand if these are common/shared or we should have different ones for the themed tokens | ||
| @use "products/css/helpers/color"; | ||
| @use "products/css/helpers/elevation"; | ||
| @use "products/css/helpers/focus-ring"; | ||
| @use "products/css/helpers/typography"; | ||
|
|
||
| // main components file | ||
| @use "../components/index"; | ||
|
|
||
| // screen-reader utility class | ||
| @use "../mixins/screen-reader-only" as *; | ||
|
|
||
| .sr-only { | ||
| @include screen-reader-only(); | ||
| } | ||
22 changes: 22 additions & 0 deletions
22
...components/src/styles/@hashicorp/design-system-components-theming-with-css-selectors.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,22 @@ | ||||||
| /** | ||||||
| * Copyright (c) HashiCorp, Inc. | ||||||
| * SPDX-License-Identifier: MPL-2.0 | ||||||
| */ | ||||||
|
|
||||||
| // these files come from `packages/tokens/dist/` | ||||||
| @use "products/css/themed-tokens/with-css-selectors/tokens.css"; | ||||||
|
||||||
| @use "products/css/themed-tokens/with-css-selectors/tokens.css"; | |
| @import "products/css/themed-tokens/with-css-selectors/tokens.css"; |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
22 changes: 22 additions & 0 deletions
22
...nts/src/styles/@hashicorp/design-system-components-theming-with-prefers-color-scheme.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,22 @@ | ||||||
| /** | ||||||
| * Copyright (c) HashiCorp, Inc. | ||||||
| * SPDX-License-Identifier: MPL-2.0 | ||||||
| */ | ||||||
|
|
||||||
| // these files come from `packages/tokens/dist/` | ||||||
| @use "products/css/themed-tokens/with-prefers-color-scheme/tokens.css"; | ||||||
|
||||||
| @use "products/css/themed-tokens/with-prefers-color-scheme/tokens.css"; | |
| @import "products/css/themed-tokens/with-prefers-color-scheme/tokens.css"; |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /** | ||
| * Copyright (c) HashiCorp, Inc. | ||
| * SPDX-License-Identifier: MPL-2.0 | ||
| */ | ||
|
|
||
| // Notice: this list can be automatically edited by the Ember blueprint, please don't remove the start/end comments | ||
| // START COMPONENTS CSS FILES IMPORTS | ||
| @use "./accordion"; | ||
| @use "./advanced-table"; | ||
| @use "./alert"; | ||
| @use "./app-footer"; | ||
| @use "./app-frame"; | ||
| @use "./app-header"; | ||
| @use "./app-side-nav"; | ||
| @use "./application-state"; | ||
| @use "./badge"; | ||
| @use "./badge-count"; | ||
| @use "./breadcrumb"; | ||
| @use "./button"; | ||
| @use "./button-set"; | ||
| @use "./card"; | ||
| @use "./code-block"; | ||
| @use "./code-editor"; | ||
| @use "./copy"; | ||
| @use "./dialog-primitive"; | ||
| @use "./disclosure-primitive"; | ||
| @use "./dismiss-button"; | ||
| @use "./dropdown"; | ||
| @use "./flyout"; | ||
| @use "./form"; // multiple components | ||
| @use "./icon"; | ||
| @use "./icon-tile"; | ||
| @use "./layout"; // multiple components | ||
| @use "./link"; // multiple components | ||
| @use "./menu-primitive"; | ||
| @use "./modal"; | ||
| @use "./page-header"; | ||
| @use "./pagination"; | ||
| @use "./reveal"; | ||
| @use "./rich-tooltip"; | ||
| @use "./segmented-group"; | ||
| @use "./separator"; | ||
| @use "./side-nav"; | ||
| @use "./stepper"; | ||
| @use "./table"; | ||
| @use "./tabs"; | ||
| @use "./tag"; | ||
| @use "./text"; | ||
| @use "./time"; | ||
| @use "./toast"; | ||
| @use "./tooltip"; | ||
| // END COMPONENT CSS FILES IMPORTS |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
@usewith a.cssfile extension is invalid in Sass. The@userule should import.scssfiles, not.cssfiles. Either change the file extension to.scssor use@importinstead.Copilot uses AI. Check for mistakes.