Twitch username display in BS+ Chat now shows display names with usernames #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChatPlexSDK_BS itself needs to also bump ChatPlexSDK to latest version as well
The default display for usernames should now be "display_name (login_name)" if the Twitch login name is different than the display name. Also, edited the Settings menu a bit to add a setting to only display login names.
This reverts commit aeae721.
|
Thanks will take a look verys soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://discord.com/channels/723117082111246416/1355978731600216378/1355978731600216378
Modifies the Twitch username display in chat so that by default, if a user has a display name that differs, case insensitive, from their login name/username (localized/international names for example), it'll show both the names, like on Twitch itself.
Also adds an option to not display international names entirely, only showing the login name. I personally didn't think this belonged with the rest of the options, so I added a "Twitch" tab.
Had to also add commit 851861b in order to get the mod to build in the first place, the commit does not need to be applied if you don't want to do so.
I have no idea what I'm doing, I've never modded Beat Saber before.