Fix 'HelpStackStoryboard' not found crash #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environment: Xcode 8, Swift 3, Cocoapods podfile with "use_frameworks!" When using use_frameworks in podfile, the "HelpStackStoryboard" is not found since it is created using manin bundle. This results in a crash when showing help. Replacing [NSBundle mainBundle] with [NSBundle bundleForClass:self.classForCoder] resolves this issue
|
Are there plans to merge this and release? At the moment we can't use helpstack because of it |
|
With these changes, I still get the crash on xCode 9 beta 4. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment: Xcode 8, Swift 3, Cocoapods podfile with "use_frameworks!"
When using use_frameworks in podfile, the "HelpStackStoryboard" is not found since it is created using main bundle. This results in a crash when showing help.
Replacing [NSBundle mainBundle] with [NSBundle bundleForClass:self.classForCoder] resolves this issue