Fix Issue #33: Restore WinAppSDK 1.7 ResourceManager behavior for XAML islands #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…XAML islands Remove CheckFile() call from GetDefaultPriFileForCurentModule() to fix regression where XAML island applications broke when resources.pri doesn't exist. This restores the exact WinAppSDK 1.7 behavior that allowed ResourceManager to work in XAML island scenarios even without PRI files present. - Fixes: GitHub Issue #33 - Regression: Introduced in WinAppSDK 1.8 - Impact: XAML islands (Win32 + WinUI3) now work again - Risk: Very low - reverts to proven 1.7 behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes regression introduced in WinAppSDK 1.8 where XAML island applications broke when
resources.prifile doesn't exist.Problem
Microsoft.Windows.ApplicationModel.Resources.ResourceManagerfails withERROR_FILE_NOT_FOUNDSolution