Fix MrmGetFilePathFromName regression for unpackaged apps in WinAppSDK 1.8 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added validation for MICROSOFT_WINDOWSAPPRUNTIME_BASE_DIRECTORY before use - Function now falls back to exe path if base directory is invalid/inaccessible - Prevents ERROR_FILE_NOT_FOUND when resources.pri doesn't exist in unpackaged scenarios - Restores WinAppSDK 1.7 behavior for XAML islands and unpackaged apps Fixes #18
haonanttt
reviewed
Oct 14, 2025
Owner
haonanttt
left a comment
haonanttt
left a comment
There was a problem hiding this comment.
🎯 Comprehensive PR Review - MrmGetFilePathFromName Regression Fix
This review focuses on logic correctness and backward compatibility for the fix addressing issue #18 where MrmGetFilePathFromName returns ERROR_FILE_NOT_FOUND in WinAppSDK 1.8 when resources.pri doesn't exist, breaking unpackaged apps and XAML islands.
📋 Review Summary
- Files reviewed: 1 (dev/MRTCore/mrt/Core/src/MRM.cpp)
- Changes: +9/-3 lines
- Focus areas: Functionality, performance, security, and documentation
- Special attention: Logic correctness of fallback behavior, backward compatibility with WinAppSDK 1.7, edge case handling
🔍 Key Review Aspects Covered:
- Functionality - Logic correctness, edge cases, and feature completeness
- Performance - Efficiency, scalability, and resource utilization
- Security - Data protection, input validation, and vulnerability assessment
- Documentation - Code clarity, comments, and maintainability
The fix appears to restore the expected behavior for unpackaged applications and XAML islands that rely on resource resolution when resources.pri files don't exist, maintaining compatibility with WinAppSDK 1.7 behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary\nFixes issue where
MrmGetFilePathFromNamereturnsERROR_FILE_NOT_FOUNDin WinAppSDK 1.8 whenresources.pridoesn't exist, breaking unpackaged apps and XAML islands.\n\n## Problem\nIn WinAppSDK 1.8, there was a regression whereMrmGetFilePathFromNamewould fail when theMICROSOFT_WINDOWSAPPRUNTIME_BASE_DIRECTORYenvironment variable points to an invalid or inaccessible directory. This breaks unpackaged applications, particularly XAML islands that rely on resource resolution.\n\n\n[Content truncated - see issue #18 for full details]