Skip to content

Fix MissingMethodException in UndockedRegFreeWinRT when creating msixbundles with trimming enabled #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix MissingMethodException in UndockedRegFreeWinRT when creating msixbundles with trimming enabled #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62879d8
Initial plan for issue
Copilot May 22, 2025
b52bc11
Add try-catch for Environment.SetEnvironmentVariable in UndockedRegFr…
Copilot May 22, 2025
ceb2aef
Add Win32 SetEnvironmentVariable fallback in UndockedRegFreeWinRT
Copilot May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file modified BuildAll.ps1
100644 → 100755
View file
Open in desktop
Empty file.
37 changes: 36 additions & 1 deletion dev/UndockedRegFreeWinRT/UndockedRegFreeWinRT-AutoInitializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ internal static class NativeMethods
{
[DllImport("Microsoft.WindowsAppRuntime.dll", CharSet = CharSet.Unicode, ExactSpelling = true)]
internal static extern int WindowsAppRuntime_EnsureIsLoaded();

// Direct Win32 API call to set environment variable as fallback
[DllImport("kernel32.dll", SetLastError = true, CharSet = CharSet.Unicode)]
[return: MarshalAs(UnmanagedType.Bool)]
internal static extern bool SetEnvironmentVariableW(string name, string value);
}

class AutoInitialize
Expand All @@ -24,7 +29,37 @@ class AutoInitialize
internal static void AccessWindowsAppSDK()
{
// Set base directory env var for PublishSingleFile support (referenced by SxS redirection)
Environment.SetEnvironmentVariable("MICROSOFT_WINDOWSAPPRUNTIME_BASE_DIRECTORY", AppContext.BaseDirectory);
try
{
Environment.SetEnvironmentVariable("MICROSOFT_WINDOWSAPPRUNTIME_BASE_DIRECTORY", AppContext.BaseDirectory);
}
catch (System.MissingMethodException)
{
// Fallback: Use direct Win32 API call when Environment.SetEnvironmentVariable is not available
// This can happen in trimmed environments (PublishTrimmed=true)
try
{
NativeMethods.SetEnvironmentVariableW("MICROSOFT_WINDOWSAPPRUNTIME_BASE_DIRECTORY", AppContext.BaseDirectory);
}
catch
{
// Ignore failures in the fallback path - continue execution
// as it's better than crashing the application
}
}
catch (System.Exception)
{
// Catch any other unexpected exceptions to ensure application doesn't crash
// Try the fallback mechanism
try
{
NativeMethods.SetEnvironmentVariableW("MICROSOFT_WINDOWSAPPRUNTIME_BASE_DIRECTORY", AppContext.BaseDirectory);
}
catch
{
// Ignore failures in the fallback path
}
}

// No error handling needed as the target function does nothing (just {return S_OK}).
// It's the act of calling the function causing the DllImport to load the DLL that
Expand Down