Skip to content

fix: iOS crash when reload #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: iOS crash when reload #1

wants to merge 1 commit into from

Conversation

@RenderCoder
Copy link

@RenderCoder RenderCoder commented Oct 12, 2022 •
edited
Loading

Crash scenario

In dev mode, after call start function, the updateStats will continue working. After reload the project, need to cancel pervious dispatch_delay function, or will crash

Solution

  • use NSTimer replace dispatch_after, easy to start or stop
  • add notification observer for RCTBridgeWillReloadNotification, will stop NSTimer before reload

Other change

  • format source code, use 4 spaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RenderCoder @bevvvis