Feature: Croesus Profit Overlay #4857

Fazfoxy · 2025-11-09T00:14:28Z

What

Neu is slowly breaking (doesn't count chest cost for instance chest profit & hasn't worked on attribute shards, ever but now this matters ever since Foraging update) & since we have Instance Chest Profit it makes some sense for us to inherit this part of NEU's equivalent features between versions since we already had half of it

Images

Changelog New Features

Croesus Profit Overlay and Highlight most profitable chest. - Fazfoxy

…oking hover Tip?

github-actions · 2025-11-10T21:24:54Z

3 Detekt Failures

Rules flagged (2): UnsafeCallOnNullableType, VarCouldBeVal

InstanceChestProfit.kt#L253 UnsafeCallOnNullableType: Calling !! on a nullable type will throw a NullPointerException at runtime in case the value is null. It should be avoided.
InstanceChestProfit.kt#L222 VarCouldBeVal: Variable 'chestList' could be val.
InstanceChestProfit.kt#L223 VarCouldBeVal: Variable 'chestTipsRenderables' could be val.

github-actions · 2025-11-10T21:52:53Z

13 Detekt Failures

Rule violations

InstanceChestProfit.kt#L238 Indentation: Unexpected indentation (16) (should be 12)
InstanceChestProfit.kt#L239 Indentation: Unexpected indentation (16) (should be 12)
InstanceChestProfit.kt#L240 Indentation: Unexpected indentation (20) (should be 16)
InstanceChestProfit.kt#L241 Indentation: Unexpected indentation (16) (should be 12)
InstanceChestProfit.kt#L242 Indentation: Unexpected indentation (16) (should be 12)
InstanceChestProfit.kt#L243 Indentation: Unexpected indentation (20) (should be 16)
InstanceChestProfit.kt#L244 Indentation: Unexpected indentation (20) (should be 16)
InstanceChestProfit.kt#L245 Indentation: Unexpected indentation (16) (should be 12)
InstanceChestProfit.kt#L246 Indentation: Unexpected indentation (16) (should be 12)
InstanceChestProfit.kt#L247 Indentation: Unexpected indentation (20) (should be 16)
InstanceChestProfit.kt#L248 Indentation: Unexpected indentation (20) (should be 16)
InstanceChestProfit.kt#L249 Indentation: Unexpected indentation (20) (should be 16)
InstanceChestProfit.kt#L250 Indentation: Unexpected indentation (16) (should be 12)

src/main/java/at/hannibal2/skyhanni/features/combat/InstanceChestProfit.kt

github-actions · 2025-11-13T21:01:10Z

1 Detekt Failure

InstanceChestProfit.kt#L135 RepoPatternRegexTestMissing: Repo pattern bookColorFixer must have a regex test.

hannibal002

not tested in game, just a first review

src/main/java/at/hannibal2/skyhanni/config/features/combat/InstanceChestProfitConfig.kt

src/main/java/at/hannibal2/skyhanni/features/combat/InstanceChestProfit.kt

…erable.table like the instance chest profit it as well?

…s a "only in Croesus" toggle to Instance Chest Profit

…esus-Profit-Overlay # Conflicts: # src/main/java/at/hannibal2/skyhanni/features/combat/InstanceChestProfit.kt

github-actions · 2025-11-25T13:19:47Z

Conflicts have been resolved! 🎉

NopoTheGamer · 2025-11-25T22:49:16Z

you cooked the merge

# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/combat/InstanceChestProfit.kt

…esus-Profit-Overlay # Conflicts: # src/main/java/at/hannibal2/skyhanni/features/combat/InstanceChestProfit.kt

NopoTheGamer

it looks like the dungeon chest key is profit when its a cost
|

Do i need the other pr for kuudra to work?

Bloxigus · 2025-12-03T19:13:31Z

src/main/java/at/hannibal2/skyhanni/features/combat/InstanceChestProfit.kt

                    val cost = itemsWithCost.values.filter { cost -> cost < 0 }.sum()
-                    add(listOf(Renderable.emptyText()))
-                    add(listOf(Renderable.text("§c§lTotal Cost"), Renderable.text("§c${cost.formatCoin()}")))
+                    add((" "))


…s seeing a completely different version on github?

I don't understnad

8234ab4

github-actions bot added the Detekt Has detekt problem label Nov 9, 2025

Fazfoxy added 5 commits November 9, 2025 10:41

I somehow understand what is broken less now, whar

f26f86b

Enchanted Book price resolution makes me feel like I am clueless as hell

235d6fa

actually functions thanks to nopo

3f60c8d

actual Attribute Detection (and it works!)

489b08a

Highlight, Book Shenanigans & Ignore already Opened Chests & Nicer lo…

cc62ac9

…oking hover Tip?

Fazfoxy marked this pull request as ready for review November 10, 2025 20:54

Fazfoxy added 2 commits November 10, 2025 21:12

Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay

0fa75ff

slightly nicer tooltip on Chests

43c1ea6

Fazfoxy added 2 commits November 10, 2025 21:41

detekt and sillyness

67069a4

non nullable internalName

a1846ea

detekt

ded0e89

github-actions bot removed the Detekt Has detekt problem label Nov 10, 2025

NopoTheGamer requested changes Nov 13, 2025

View reviewed changes

CalMWolfs requested changes Nov 13, 2025

View reviewed changes

src/main/java/at/hannibal2/skyhanni/features/combat/InstanceChestProfit.kt Outdated Show resolved Hide resolved

Fazfoxy added 3 commits November 13, 2025 18:53

currentLoreLine --> loreLine (why did I make it current that's stupid)

afad11c

Book resolution MUCH Cleaner

51bb08f

formatting

e4801a9

github-actions bot added the Detekt Has detekt problem label Nov 13, 2025

detekt

bb55ce6

github-actions bot removed the Detekt Has detekt problem label Nov 13, 2025

Fazfoxy and others added 4 commits November 14, 2025 00:52

Useless Reset removal.

9c5e715

Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay

d45d291

Merge branch 'refs/heads/beta' into fork/Fazfoxy/Croesus-Profit-Overlay

a33c6b7

cleanup

5a786ac

hannibal002 requested changes Nov 14, 2025

View reviewed changes

Fazfoxy and others added 18 commits November 25, 2025 13:12

Book resolution MUCH Cleaner

44289dc

formatting

2491885

detekt

3e59818

Useless Reset removal.

9ef813b

merge conflicts

aec77c0

I can't actually think of a way to do this that isn't reliant on rend…

4b5b8c1

…erable.table like the instance chest profit it as well?

the mega commit of review changes (oops)

f9ee2fd

Lies now

dadbc10

detekt less hating of me?

406b9f0

merge conflicts

f976292

lets not use renderable.table to create lists actually

421a94e

Config name for new feature felt silly

44a4563

maybe make config link work

7f22ab1

using more strings

0fce0b2

no longer throw Missing Item Errors at the user

3690c7a

This should be a good name for the future if someone inexplicably add…

cdecdc1

…s a "only in Croesus" toggle to Instance Chest Profit

merge conflicts

9a01904

Merge remote-tracking branch 'origin/Croesus-Profit-Overlay' into Cro…

25bcacc

…esus-Profit-Overlay # Conflicts: # src/main/java/at/hannibal2/skyhanni/features/combat/InstanceChestProfit.kt

github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Nov 25, 2025

Fazfoxy added 3 commits November 26, 2025 04:25

Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay

0e25aca

Merge branch 'beta' into Croesus-Profit-Overlay

6ba47cb

# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/combat/InstanceChestProfit.kt

Merge remote-tracking branch 'origin/Croesus-Profit-Overlay' into Cro…

8e63fea

…esus-Profit-Overlay # Conflicts: # src/main/java/at/hannibal2/skyhanni/features/combat/InstanceChestProfit.kt

NopoTheGamer requested changes Nov 27, 2025

View reviewed changes

Kuudra chest fix

962c539

Bloxigus reviewed Dec 3, 2025

View reviewed changes

Fazfoxy added 3 commits December 3, 2025 19:27

I'm not even sure what's going on here because I'm pretty sure Blox i…

1685e3d

…s seeing a completely different version on github?

Dungeon Chest Key Fix

b69c0b6

Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay

d91d987

Uh oh!

Feature: Croesus Profit Overlay #4857

Are you sure you want to change the base?

Feature: Croesus Profit Overlay #4857

Conversation

Fazfoxy commented Nov 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Changelog New Features

Uh oh!

github-actions bot commented Nov 10, 2025

3 Detekt Failures

Uh oh!

github-actions bot commented Nov 10, 2025

13 Detekt Failures

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 13, 2025

1 Detekt Failure

Uh oh!

hannibal002 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

NopoTheGamer commented Nov 25, 2025

Uh oh!

NopoTheGamer left a comment

Choose a reason for hiding this comment

Uh oh!

Bloxigus Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Fazfoxy commented Nov 9, 2025 •

edited

Loading