-
Notifications
You must be signed in to change notification settings - Fork 258
feat: encode added routes #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
huseeiin
wants to merge
3
commits into
h3js:main
Choose a base branch
from
huseeiin:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encode pathname before adding route
add tests for arabic routes
@pi0 you might need to rerun prettier because i didn't have time to do that |
pi0
reviewed
Feb 19, 2025
src/h3.ts
Outdated
@@ -277,7 +277,7 @@ class _H3 implements H3 { | |||
} | |||
const _method = (method || "").toUpperCase(); | |||
const _handler = (handler as H3)?.handler || handler; | |||
addRoute(this._router, _method, route, <H3Route>{ | |||
addRoute(this._router, _method, new URL(route, "http://localhost").pathname, <H3Route>{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably do manual encoding (or do it behind a flag) since URL
constructor adds runtime overhead
(from chat) const preservedChars = [
"%",
"[",
"]",
"!",
"*",
"'",
"(",
")",
";",
":",
"@",
"&",
"=",
"+",
"$",
",",
"/",
"?",
"#",
"-",
];
/**
* Transform the `pathname` segment of a URL like the browser does.
*/
export function sanitizePathname(url: string) {
url = String(url);
const segments = url.replace(/\\/g, "/").split("/");
const normalizedSegments: string[] = [];
for (const segment of segments) {
if (segment === "") {
continue;
}
if (segment === ".") {
continue;
}
if (segment === "..") {
if (normalizedSegments.length > 0) {
normalizedSegments.pop();
}
} else {
normalizedSegments.push(segment);
}
}
const result = normalizedSegments
.join("/")
.split("")
.map((char) =>
preservedChars.includes(char) ? char : encodeURIComponent(char)
)
.join("");
return result.startsWith("/") ? result : `/${result}`;
} |
348028f
to
a449d79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now you can add h3 routes with arabic letters.