Skip to content

feat: support File response with auto Content-Disposition header #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025

Conversation

kricsleo
Copy link
Member

resolves #619

@kricsleo kricsleo requested a review from pi0 as a code owner April 23, 2025 06:09
@kricsleo kricsleo changed the title feat: automatically set Content-Disposition for File response feat(response): automatically set Content-Disposition for File response Apr 23, 2025
@pi0 pi0 changed the title feat(response): automatically set Content-Disposition for File response feat: support File response with auto Content-Disposition header Apr 23, 2025
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit bea54cf into h3js:main Apr 24, 2025
4 checks passed
@pi0
Copy link
Member

pi0 commented Apr 24, 2025

we need to update docs to add File (https://h3.dev/guide/handler#blob)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Blob metadata
2 participants