fix: ensure callNodeListener
resolves after res.end()
is called
#1028
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #779
This is a minimal quick fix for
h3@v1
. (I'm not sure if it still needs fixing, though 🤔)The
res.once
binding was happening too late. Sometimes,res.end()
would be called and the events would have already fired, preventing the callbacks from firing. This would cause the response to hang indefinitely.The WIP
h3@2
doesn't need this fix because it binds earlier:h3/src/adapters.ts
Lines 75 to 80 in ac609aa