Add --no-portable flag

[wheremyfoodat]

Useful on MacOS where app bundles are always going to store settings, memcards, etc in $HOME/.config/pcsx-redux. I use this flag to make my dev builds use the same persistent directory as app bundles, so as not to have multiple copies of those files.

One could also use the --portable flag with an appropriate path to achieve the same thing, but this is easier to use since you don't need to remember the correct path.

[coderabbitai]

Walkthrough

Introduces a command-line flag to disable portable mode. The arguments constructor now checks for a no-portable flag after existing portable detection and the portable flag, and forces m_portable to false when present.

Changes

Cohort / File(s)	Summary
Argument parsing: portable override src/core/arguments.cc	Added parsing for a no-portable flag. After auto-detection and the portable flag, no-portable sets m_portable=false, giving it highest precedence. No signature changes.

Sequence Diagram(s)

sequenceDiagram
    actor User
    participant CLI as CommandLine
    participant Args as PCSX::Arguments
    participant FS as Filesystem

    User->>CLI: launch with flags
    CLI->>Args: construct with args
    Args->>FS: check pcsx.json / repo paths
    FS-->>Args: detection result (portable?)
    Args->>Args: apply --portable if present
    Args->>Args: apply --no-portable (overrides to false)
    Args-->>CLI: m_portable finalized

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

I twitch my nose at flags that flow,
A hop to “portable,” then “no.”
With final say, the burrow’s set—
Override wins, no sweat.
Carrots parsed, decisions made,
The path is clear, no shade. 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4f4a00f and 169788f.

📒 Files selected for processing (1)

• src/core/arguments.cc (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: pcsx-redux (aarch64-linux)
• GitHub Check: pcsx-redux (x86_64-linux)
• GitHub Check: build
• GitHub Check: cross-arm64
• GitHub Check: macos-build-and-test-toolchain
• GitHub Check: asan
• GitHub Check: build-openbios
• GitHub Check: aur-build
• GitHub Check: toolchain
• GitHub Check: coverage

🔇 Additional comments (1)

src/core/arguments.cc (1)

38-38: LGTM! Clean implementation of the --no-portable flag.

The placement after all portable detection logic ensures that --no-portable correctly overrides any auto-detection or explicit --portable settings, which aligns with the intended behavior described in the PR objectives.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.