Skip to content

Added an error message bag for connection issues with LDAP #17955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Added an error message bag for connection issues with LDAP #17955

wants to merge 8 commits into from

Conversation

Godmartinz
Copy link
Member

This adds error handling around LDAP login. if it times out, it does so with an amorphous response:

image

@Godmartinz Godmartinz requested a review from snipe as a code owner September 30, 2025 18:21
snipe
snipe reviewed Oct 1, 2025
View reviewed changes
@snipe snipe changed the title adds an error message bag for connection issues with LDAP Added an error message bag for connection issues with LDAP Oct 1, 2025
@Godmartinz
Copy link
Member Author

@uberbrady I made some changes around the self::bindAdminToLdap($connection), You left a warning about it. but I think with the throws, it should be handled now. But I really would like your blessing or input on this before this moves forward.
The tests were failing because the if statement on Model/Ldap.php:173 was returns on failure and nothing on success, I am just calling self::bindAdminToLdap($connection) instead now. Let me know iwhat you think. Please and thank you 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snipe snipe snipe left review comments

@uberbrady uberbrady Awaiting requested review from uberbrady

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Godmartinz @snipe