Fixed #8709 - Bulk Deletion of Categories, Suppliers, Manufa...

[spencerrlongg]

Alright, this looks like more than it is. I've gone ahead and refactored the existing delete controller methods into actions with new exceptions to be thrown when one of the disallowed conditions has been met.

There's few reasons for this.

1. The actions make this so that the bulk controllers and the standard controllers are all nearly identical, the only differences are the foreach and the error gathering.

2. As we continue to expand our use of actions (fingers crossed) those Exceptions are re-usable and create a simple pattern for what to do when one of these things happen

3. If we need to make a change to how we delete one of these things, it's painfully simple to go do that in one place and have it work the same across the board (for instance, there were some inconsistencies while I was doing this, like not always also deleting the picture associated with the deleted object)

On the frontend, I went ahead and just duplicated asset-bulk-actions.blade.php to similar ones for the new supported models, I started writing a bunch of conditionals in the original blade with the intention of re-using it and decided it was starting to look too messy.

What should probably happen eventually is a single component with good props that can handle all of these, but the amount of refactor that would've required seemed too much for this PR considering it's already fairly large and has taken some time.

I'm sure there will be some questions and I look forward to the conversation!

[spencerrlongg]

Oops, forgot to rename maintenances - done!

[uberbrady]

Here's the stuff we went over when we went through this PR - I'm feeling pretty good about it, myself. Please let me and/or @snipe know when you've been able to address those - or ping me in Slack if you have any specific questions.

[uberbrady]

I kinda feel like all these checks could get put in something like:

public function throwIfNotDeletable()
{
   //grab counts, throw the new exceptions as appropriate
}

And then you can make is_deletable() just be like this:

public function is_deletable()
{
   try {
      $this->throwIfNotDeletable();
      } catch (BaseExceptionWhateverItsCalled $e) {
        return false;
   } catch (Exception $e) {
     //do something else?
  }
  }

[spencerrlongg]

@uberbrady / @snipe this should be ready to go now

[snipe]

Some comments inline

[spencerrlongg]

Should be good to go now.