-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Adds file upload deletion logging #16599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly solid but there are a couple inconsistencies we should fix up before merging.
- Consumables don't show the filename like other histories do
- Deleting a file update for a component hides
uploaded
action from the history view
- you can still download a "deleted" file from a license history. It's not actually being removed.
This doesn't occur for the other first class items
Some of this might not be caused by this PR but we should probably make them uniform.
Also, should we include users in this? I think it's in the same boat as components where the file history isn't surfaced but can be.
I think the history formatting stuff would likely be handled via this WIP #16769 |
Really nice work here @Godmartinz - a lot of it doesn't apply anymore since the new file uploads controller (since those FooFilesControllers don't exist anymore), but I'm nicking part of it for a new PR that does the same thing in the new way. Sorry, and thank you! :D |
all good, also I didnt realize I had changes to apply 😬 🤦 |
This adds logging for deletion of uploads across assets, accessories, licenses, consumables and components.

While components history is not currently surfaced, changes are reflected in the
action_logs
table.[sc-28213]
Deletions have a trash icon:
This updates the
uploads()
relationships on all models mentioned above to exclude all filenames that have been deleted so theFile Uploads
tabs correctly reflect what is actually still being stored.