-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Tmp ldapauth2 #11715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Tmp ldapauth2 #11715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exquisite. Let me test a little then I’d love to accept. Thank you!
Signed-off-by: Katharina Drexel <[email protected]>
c884814
to
7a59a9b
Compare
@uberbrady any luck testing this? I'd love to get this merged or closed. |
Ping @uberbrady :) |
@uberbrady is this PR still necessary given all of the other changes we've made since it was opened? |
@snipe I'm afraid so; I do still think it could be useful. Unfortunately my test rig still isn't quite working yet. We might need to ask @Godmartinz to test? |
@uberbrady re-ping on this for v7. I know the test rig is up. Can you test this? |
Does this #17832 PR do the same thing as yours? |
Description
This is just a slight enhancement of "Fixed #9063: Ask LDAP for user DN, don't concatenate username+baseDN." ->
#11544
Fixes #9063
Type of change
How Has This Been Tested?
The same way as in #11544
Test Configuration:
Checklist: