Skip to content

I would like to get this change committed into master. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

I would like to get this change committed into master. #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 10 additions & 18 deletions jquery.uitableedit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
* arguments are the cell's text, original text, event, jquery object for the cell
* editDone : invoked on completion
* arguments: td cell's new text, original text, event, and jquery element for the td cell
*
* changes DTU: introduced classes
* td.uiTableEdit_noEdit This entry will not be editable
* input.uiTableEdit_editable The input class to mark it current editable
*/
jQuery.uiTableEdit = function(jq, options){
function unbind(){
Expand All @@ -32,7 +36,7 @@ jQuery.uiTableEdit = function(jq, options){
options = options || {}
options.find = options.find || 'tbody > tr > td'
if( options.off ){
unbind().find('form').each( function(){ var f = $(this);
unbind().find('form').each( function(){var f = $(this);
f.parents("td:first").text( f.find(':text').attr('value') );
f.remove();
});
Expand All @@ -44,17 +48,17 @@ jQuery.uiTableEdit = function(jq, options){
}
function td_edit(){
var td = jQuery(this);
if (td.hasClass('uiTableEdit_noEdit')) return; // do nothing

function restore(e){
var val = td.find(':text').attr('value')
if( options.dataVerify ){
var value = options.dataVerify.call(this, val, orig_text, e, td);
if( value === false ){ return false; }
if( value === false ){return false;}
if( value !== null && value !== undefined ) val = value;
}
td.html( "" );
td.text( val );
td.css( orig_css );
if( options.editDone ) options.editDone(val,orig_text,e,td)
bind_mouse_down( td_edit_wrapper );
}
Expand All @@ -63,33 +67,21 @@ jQuery.uiTableEdit = function(jq, options){
if (e.keyCode === 27) {
td.html( "" );
td.text( orig_text );
// gmiranda: restore style
td.css( orig_css );
bind_mouse_down( td_edit_wrapper );
}
}

var orig_text = td.text();
// gmiranda <[email protected]> {: save the original style, too.
var w = td.width();
var h = td.height();
// I keep the new style in this object to copy the keys that we need to
// restore later on.
var new_css = {width: w + "px", height: h + "px", padding: "0", margin: "0"};
var orig_css = new Object();
for( var propertyName in new_css ){
var value = td.css( propertyName );
orig_css[ propertyName ] = value;
}
td.css( new_css );
// }gmiranda
td.css({width: w + "px", height: h + "px", padding: "0", margin: "0"});
td.html( '<form name="td-editor" action="javascript:void(0);">' +
'<input type="text" name="td_edit" value="' +
'<input type="text" name="td_edit" class="uiTableEdit_editable" value="' +
td.text() + '"' + ' style="margin:0px;padding:0px;border:0px;width: ' +
w + 'px;">' + '</input></form>' )
.find('form').submit( restore ).mousedown( restore ).blur( restore ).keypress( checkEscape );

function focus_text(){ td.find('input:text').get(0).focus() }
function focus_text(){td.find('input:text').get(0).focus()}

// focus bug (seen in FireFox) fixed by small delay
setTimeout(focus_text, 50);
Expand Down