fix: llm api menu and other errors #13842
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nive1980
force-pushed
the
APIM-11657-Adapt-UI-for-llm-new
branch
7 times, most recently
from
420d60e to
1e40af6
Compare
jgiovaresco
reviewed
Oct 27, 2025
| ...(api.type === 'PROXY' ? [this.addDebugMenuEntry()] : []), | ||
| ].filter((entry) => entry != null && !entry.tabs?.every((tab) => tab.routerLink === 'DISABLED')); | ||
| ] | ||
| .flat() |
There was a problem hiding this comment.
I'm not sure to understand why it is required 🤔
| ApiType.LLM_PROXY, | ||
| flow -> | ||
| flow | ||
| // TODO(LLM_PROXY): Add a specific LLM selector and use it here |
There was a problem hiding this comment.
I think we can remove this todo because we won't have LLM selector like MCP
|
|
||
| private void checkSelectorsForType(final ApiType apiType, final Flow flow) { | ||
| if (flow.getSelectors() != null) { | ||
| if (ApiType.PROXY == apiType) { |
There was a problem hiding this comment.
What about adding
Suggested change
| if (ApiType.PROXY == apiType || ApiType.LLM_PROXY == apiType) { |
instead of creating a new if branch?
LLM Proxy use regular HTTP selectors
| .contains(entry("flowName", "bad_flow"), entry("invalidSelectors", "http")); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
is it expected to remove this 🤔
nive1980
force-pushed
the
APIM-11657-Adapt-UI-for-llm-new
branch
3 times, most recently
from
113d11f to
04309a3
Compare
nive1980
force-pushed
the
APIM-11657-Adapt-UI-for-llm-new
branch
4 times, most recently
from
a18b29e to
21ddba4
Compare
nive1980
force-pushed
the
APIM-11657-Adapt-UI-for-llm-new
branch
from
21ddba4 to
b5fcce7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://gravitee.atlassian.net/browse/APIM-11657
Description
Fixed LLM API Menus, api_key plan other issues.