Skip to content

Conversation

@aatuvai
Copy link
Contributor

@aatuvai aatuvai commented Aug 6, 2025

This PR adds the new docs navigation bar for the revamp.

Closes #279
Closes #170

@github-actions
Copy link

github-actions bot commented Aug 6, 2025

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
aatuvai/docs-top-nav 139a424 39 ✅SUCCEED aatuvai-docs-top-nav 2025-10-27 13:35:39

Base automatically changed from travis.rodgers/docs-homepage-header to main August 11, 2025 06:44
.gitmodules Outdated
Comment on lines 7 to 8
url = https://github.com/aatuvai/teleport/
branch = aatuvai/docs-header
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert before merge to main

@aatuvai aatuvai marked this pull request as ready for review August 13, 2025 07:59
@aatuvai aatuvai requested a review from rodgtr1 August 13, 2025 07:59
@aatuvai aatuvai changed the title Docs Homepage: add docs navigation bar Docs navigation update Sep 30, 2025
@ptgott
Copy link
Contributor

ptgott commented Sep 30, 2025

@aatuvai I just updated my PR to configure the docs for multiple sidebars:

I think this looks really nice with the top nav, though it doesn't seem like there's a way to navigate between sidebars on mobile. Is that expected? Thanks!

@aatuvai
Copy link
Contributor Author

aatuvai commented Sep 30, 2025

@aatuvai I just updated my PR to configure the docs for multiple sidebars:

I think this looks really nice with the top nav, though it doesn't seem like there's a way to navigate between sidebars on mobile. Is that expected? Thanks!

Thanks for catching this @ptgott! I'll make sure to check that navigating between sidebars works on mobile.

@ptgott
Copy link
Contributor

ptgott commented Oct 9, 2025

@aatuvai Should we put this in draft until mobile navigation is ready?

@aatuvai aatuvai marked this pull request as draft October 10, 2025 06:13
@aatuvai
Copy link
Contributor Author

aatuvai commented Oct 10, 2025

@ptgott I converted it to draft

@aatuvai
Copy link
Contributor Author

aatuvai commented Oct 10, 2025

@ptgott I added the global sidebar to the config in my fork so it at least shows up on the home page. However I'm not sure how to solve the issue with not being able to switch the sidebars once you go to sub pages. Do you know if there's a way to use the global sidebar config for mobile only and use the individual sidebars on the desktop view?

@ptgott
Copy link
Contributor

ptgott commented Oct 10, 2025

@ptgott I added the global sidebar to the config in my fork so it at least shows up on the home page. However I'm not sure how to solve the issue with not being able to switch the sidebars once you go to sub pages. Do you know if there's a way to use the global sidebar config for mobile only and use the individual sidebars on the desktop view?

Per the Docusaurus docs, Docusaurus associates each page with a sidebar using the sidebar configuration, and you can manually specify a sidebar for a page using the displayed_sidebar frontmatter field. This doesn't seem to be much help for mobile, though, since as far as I understand it, Docusaurus reads frontmatter at build time.

We may need a component that allows users to switch sidebars on mobile.

@aatuvai aatuvai marked this pull request as ready for review October 27, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants