Skip to content

Conversation

jsoref
Copy link

@jsoref jsoref commented Jul 9, 2025

  • it's possible to end up w/ "Windows" line endings in ongdb.conf and when that happens running the unix ongdb release script with that file results in a very unhappy system. Tolerating those line endings seems reasonable, as users generally expect conf files to be portable and not to need to worry about line endings.
  • one should be able to run ongdb version without java preallocated gb's of memory for ongdb -- we have containers that run with enough space for one copy of ongdb but definitely not enough space for two copies of ongdb, but it should be possible to run ongdb version as that doesn't require the preallocation defined in ongdb.conf -- Simplify the start script to do minimal work when getting version (skipping setup_java_opts, most of setup_arbiter_options).

@bradnussbaum
Copy link
Contributor

These changes seem reasonable to me. I'm good with both of them. Build is failing during testing of server assembly. I think we discussed elsewhere that test expectations need updated following the changes to the version command.

ongdb does not need special memory information when running version
@jsoref jsoref force-pushed the start-script-improvements branch from d797077 to eae1430 Compare August 7, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants