Skip to content

Website V2 #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Website V2 #389

wants to merge 37 commits into from

Conversation

alex-snezhko
Copy link
Member

Website redesign, stack:

  • Astro
  • Tailwind
  • Svelte

@alex-snezhko alex-snezhko force-pushed the v2-astro branch 2 times, most recently from a65f6be to 2bbd454 Compare November 28, 2024 02:52
Copy link

netlify bot commented Nov 28, 2024

Deploy preview ready! 🌾

Name Link
🔨 Latest commit c16caef
🔍 Latest deploy log https://app.netlify.com/sites/grain-lang/deploys/67a01bd08fe2d40008567b7f
😎 Deploy Preview https://deploy-preview-389--grain-lang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this Alex, the new site is amazing and the share feature on the playground is awesome for being able to share reproducable snippets. Most of my feedback is small a tiny bit of will need a bit of discussion I think and I also left some docs fixes but I don't know if we want to address those in this pr or not.

Below is some general feedback that did not really relate to any file in particular or I couldn't find where it would need to be changed.

Blog

  • If you take a look here you'll notice we have an include ModuleName inline, I feel like the style is slightly off maybe we add a tiny bit more padding, slight border or make the background a tiny bit darker? I think discord does a really good job with the style of these for inspiration.
  • There seems to be some overflow on mobile in the description of the docs, I really don't know the best way for this to be fixed, in the example below example we could certainly reduce the padding around the param column but that doesn't seem like a full fix, maybe we should open an issue for this though if we can't come up with something better as I would argue it's minor? Screenshot 2024-12-09 at 7 34 39 PM
  • Can we use https://docs.astro.build/en/recipes/rss/ to add the blogs rss feed back.
    • I think it would be fine if we opened an issue and handled this in a separate pr.

changeView(0);
</script>

<div class="flex flex-col relative h-full w-full">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In light mode this stays dark, I found the contrast between the light background and this to be way to much making it really hard to read. (I noticed we might have the same issue on codeblocks in the docs as well), I don't know the best fix but I think if we just made the purple a bit more faded in lightmode (maybe we head more towards a lavender) it would help a lot.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just use a light theme in light mode altogether? cc @ospencer @phated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file specifically is the home page hero with the code examples, but I was asking if we should just change all rendered code blocks in light mode to be a light theme

Copy link
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of accessibility notes I forgot in the first review as well, the mobile nav button also needs an aria label.

@spotandjake
Copy link
Member

Closes:
#46
#88
#142
#348
#356
#365
#388
#192
#353

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the grain compile options table was outdated, maybe we could autogenerate it either by hooking into commander (maybe with a hidden help-table <cmd_name>) command or just by using awk with --help so it stays in sync.

We could also consider generating the tables from the other commands and maybe putting them under a dropdown (similar to history elements in graindoc).

Here is the current table (this will probably be out of date by the time we release):

| -I, --include-dirs <dirs>     | add additional dependency include directories                               |
| -S, --stdlib <path>           | override the standard library with your own                                 |
| -o <filename>                 | output filename                                                             |
| --initial-memory-pages <size> | initial number of WebAssembly memory pages                                  |
| --maximum-memory-pages <size> | maximum number of WebAssembly memory pages                                  |
| --import-memory               | import the memory from `env.memory`                                         |
| --elide-type-info             | don't include runtime type information used by toString/print               |
| --release                     | compile using the release profile (production mode)                         |
| --no-wasm-tail-call           | disables tail-call optimization                                             |
| --debug                       | compile with debugging information                                          |
| --wat                         | additionally produce a WebAssembly Text (.wat) file                         |
| --hide-locs                   | hide locations from intermediate trees. Only has an effect with `--verbose` |
| --no-color                    | disable colored output                                                      |
| --no-gc                       | turn off reference counting garbage collection                              |
| --no-bulk-memory              | polyfill WebAssembly bulk memory instructions                               |
| --wasi-polyfill <filename>    | path to custom WASI implementation                                          |
| --use-start-section           | replaces the \_start export with a start section during linking             |
| --single-file                 | compile a single file without compiling                                     |
| --no-link                     | disable static linking                                                      |
| --no-pervasives               | don't automatically import the Grain Pervasives module                      |
| --memory-base <addr>          | set the base address for the Grain heap                                     |
| --source-map                  | generate source maps                                                        |
| --strict-sequence             | enable strict sequencing                                                    |
| --verbose                     | print critical information at various stages of compilation                 |
| -h, --help                    | display help for command                                                    |

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The asdf community install here still points to grain 0.4.6.

We should either make sure the release process updates this as well or I feel like a better idea would be to add an entry for community releases to awesome-grain and manage it there, with the idea being thats the place for all community stuff in general. I also have a nix distribution we could add in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants