feat(generator): emit typed JSON parsing and handle void/non-JSON responses #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponses Only JSON-parse when the response content-type is application/json and emit an explicit typed `const data = response.json() as ...`. Fall back to `response.body` for non-JSON responses and omit the `data` field for void responses. Update generated examples, fixtures and generator tests (add empty_response sample) to match the new output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only JSON-parse when the response content-type is application/json and emit an explicit typed
const data = response.json() as .... Fall back toresponse.bodyfor non-JSON responses and omit thedatafield for void responses. Update generated examples, fixtures and generator tests (add empty_response sample) to match the new output.fixes #55