Skip to content

fix(helm): make loki.storage.bucketNames are optional, if builtin minio is enabled. #18653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2025

Conversation

jkroepke
Copy link
Contributor

What this PR does / why we need it:

If minio is enabled, the names of the bucket names are hard-coded and loki.storage.bucketNames is ignored.

{{- if .Values.minio.enabled -}}
s3:
endpoint: {{ include "loki.minio" $ }}
bucketnames: chunks

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

CI is currently failing: https://github.com/grafana/loki/actions/runs/16606809856/job/46981528703?pr=18510

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@jkroepke jkroepke requested a review from a team as a code owner July 29, 2025 21:36
@Jayclifford345 Jayclifford345 enabled auto-merge (squash) July 30, 2025 09:41
@Jayclifford345 Jayclifford345 merged commit 409ccbd into grafana:main Jul 30, 2025
74 checks passed
@jkroepke jkroepke deleted the minio branch July 30, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants