Skip to content

Conversation

dehaansa
Copy link
Contributor

PR Description

Update the mongodb dependencies to get the update from aws-sdk to aws-sdk-v2 for #2936 . There may be a few new metrics, but appear to be no other user facing changes.

  • CHANGELOG.md updated

@dehaansa dehaansa requested a review from a team as a code owner September 15, 2025 21:13
@kgeckhart
Copy link
Contributor

kgeckhart commented Sep 16, 2025

Looking at the test failure it seems like this somehow changed the output ordering for the test 🤔

FAIL: TestConvert/integrations.yaml and FAIL: TestConvert/integrations_v2.yaml

-prometheus.exporter.mongodb "integrations_mongodb_exporter" {
            	            	-	mongodb_uri      = "mongodb://mongodb-a:27017"
            	            	-	direct_connect   = true
            	            	-	discovering_mode = true
            	            	-}
            	            	-
            	            	-discovery.relabel "integrations_mongodb_exporter" {
            	            	-	targets = prometheus.exporter.mongodb.integrations_mongodb_exporter.targets
            	            	-
            	            	-	rule {
            	            	-		source_labels = ["__address__"]
            	            	-		target_label  = "service_name"
            	            	-		replacement   = "replicaset1-node1"
            	            	-	}
            	            	-
            	            	-	rule {
            	            	-		source_labels = ["__address__"]
            	            	-		target_label  = "mongodb_cluster"
            	            	-		replacement   = "prod-cluster"
            	            	-	}
            	            	-
            	            	-	rule {
            	            	-		target_label = "instance"
            	            	-		replacement  = "instance-key-value"
            	            	-	}
            	            	-
            	            	-	rule {
            	            	-		target_label = "job"
            	            	-		replacement  = "integrations/mongodb_exporter"
            	            	-	}
            	            	-}
            	            	-
            	            	-prometheus.scrape "integrations_mongodb_exporter" {
            	            	-	targets    = discovery.relabel.integrations_mongodb_exporter.output
            	            	-	forward_to = [prometheus.remote_write.integrations.receiver]
            	            	-	job_name   = "integrations/mongodb_exporter"
            	            	-
            	            	-	tls_config {
            	            	-		ca_file   = "/something7.cert"
            	            	-		cert_file = "/something8.cert"
            	            	-		key_file  = "/something9.cert"
            	            	-	}
            	            	-}
            	            	-
            	            	 prometheus.exporter.mssql "integrations_mssql" {
            	            	@@ -786 +742,45 @@
            	            	 
            	            	+prometheus.exporter.mongodb "integrations_mongodb_exporter" {
            	            	+	mongodb_uri      = "mongodb://mongodb-a:27017"
            	            	+	direct_connect   = true
            	            	+	discovering_mode = true
            	            	+}
            	            	+
            	            	+discovery.relabel "integrations_mongodb_exporter" {
            	            	+	targets = prometheus.exporter.mongodb.integrations_mongodb_exporter.targets
            	            	+
            	            	+	rule {
            	            	+		source_labels = ["__address__"]
            	            	+		target_label  = "service_name"
            	            	+		replacement   = "replicaset1-node1"
            	            	+	}
            	            	+
            	            	+	rule {
            	            	+		source_labels = ["__address__"]
            	            	+		target_label  = "mongodb_cluster"
            	            	+		replacement   = "prod-cluster"
            	            	+	}
            	            	+
            	            	+	rule {
            	            	+		target_label = "instance"
            	            	+		replacement  = "instance-key-value"
            	            	+	}
            	            	+
            	            	+	rule {
            	            	+		target_label = "job"
            	            	+		replacement  = "integrations/mongodb_exporter"
            	            	+	}
            	            	+}
            	            	+
            	            	+prometheus.scrape "integrations_mongodb_exporter" {
            	            	+	targets    = discovery.relabel.integrations_mongodb_exporter.output
            	            	+	forward_to = [prometheus.remote_write.integrations.receiver]
            	            	+	job_name   = "integrations/mongodb_exporter"
            	            	+
            	            	+	tls_config {
            	            	+		ca_file   = "/something7.cert"
            	            	+		cert_file = "/something8.cert"
            	            	+		key_file  = "/something9.cert"
            	            	+	}
            	            	+}
            	            	+

@dehaansa
Copy link
Contributor Author

Looking at the test failure it seems like this somehow changed the output ordering for the test 🤔

Well that's... very strange. I don't see any reason why that happened, I was able to reproduce it locally so I guess I'll keep digging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants