postgres_exporter: expose stat_statements.include_query #4372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Serrano/alloy into ss/postgres_exporter-flags
SimonSerrano
requested review from
a team and
clayton-cornell
as code owners
|
@dehaansa Hello, I would be very happy to have a review from you 😊 |
docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md
Outdated
Show resolved
Hide resolved
internal/static/integrations/postgres_exporter/postgres_exporter.go
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
…Serrano/alloy into ss/postgres_exporter-flags
internal/static/integrations/postgres_exporter/postgres_exporter.go
Outdated
Show resolved
Hide resolved
internal/static/integrations/postgres_exporter/postgres_exporter.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Cristian Greco <[email protected]>
|
@SimonSerrano there are some failing tests in |
|
Alright, I am fixing the failing test and we should be good 😁 |
…es exporter integration config
Thanks for looking into it. CI is still red unfortunately, there are a few more things that need to be updated I guess. |
internal/converter/internal/staticconvert/testdata-v2/integrations_v2.alloy
Outdated
Show resolved
Hide resolved
…ents by default" This reverts commit 2bc5c1a.
…er components of same types grafana#4004
docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md
Outdated
Show resolved
Hide resolved
…atch other components of same types grafana#4004" This reverts commit 672fadc.
Make `StatStatementFlags` optional
matthewnolf
approved these changes
Oct 9, 2025
cristiangreco
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Fixes #4004
Notes to the Reviewer
To fix this, the code heavily relies on Kingpin and the naming of the argument on the upstream repo https://github.com/prometheus-community/postgres_exporter. This is the best I could come up with without changing the upstream first. If you have another approach given your experience, I will happily change this PR.
PR Checklist