Add missing SetDashboardParams #117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
GiedriusS
requested changes
Nov 8, 2020
Collaborator
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
Looks good but one suggestion. Sorry for the late response. I think we should help our users by using a more strict type. Let me know what do you think.
| newBoard.FolderID = params.FolderID | ||
| newBoard.Overwrite = params.Overwrite | ||
| newBoard.Message = params.Message | ||
| newBoard.Refresh = params.Refresh |
Collaborator
There was a problem hiding this comment.
Then do:
Suggested change
| newBoard.Refresh = params.Refresh | |
| newBoard.Refresh = params.Refresh.Round(time.Second).String() |
| FolderID int | ||
| Overwrite bool | ||
| Message string | ||
| Refresh string |
Collaborator
There was a problem hiding this comment.
Let's do:
Suggested change
| Refresh string | |
| Refresh time.Duration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing fields
messageandrefreshforPOST /api/dashboards/dbcall.