Skip to content

feat: Add oauthbearer support for sasl #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add oauthbearer support for sasl #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
122f17d
test: add should accept oauthbearer
ekawinataa Sep 25, 2024
46381d6
feature: add OAUTHBEARER to SUPPORTED_SOURCE_KAFKA_CONSUMER_CONFIG_SA…
ekawinataa Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dagger-core/src/main/java/com/gotocompany/dagger/core/utils/Constants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ public enum ExternalPostProcessorVariableType { REQUEST_VARIABLES, HEADER_VARIAB
public static final String SINK_ERROR_TYPES_FOR_FAILURE_DEFAULT = "";

public static final String[] SUPPORTED_SOURCE_KAFKA_CONSUMER_CONFIG_SECURITY_PROTOCOL = {"SASL_PLAINTEXT", "SASL_SSL", "SSL"};
public static final String[] SUPPORTED_SOURCE_KAFKA_CONSUMER_CONFIG_SASL_MECHANISM = {"PLAIN", "SCRAM-SHA-256", "SCRAM-SHA-512"};
public static final String[] SUPPORTED_SOURCE_KAFKA_CONSUMER_CONFIG_SASL_MECHANISM = {"PLAIN", "SCRAM-SHA-256", "SCRAM-SHA-512", "OAUTHBEARER"};

public static final String[] SUPPORTED_SOURCE_KAFKA_CONSUMER_CONFIG_SSL_PROTOCOL = {"TLS", "TLSv1.1", "TLSv1.2", "TLSv1.3", "SSL", "SSLv2", "SSLv3"};
public static final String[] SUPPORTED_SOURCE_KAFKA_CONSUMER_CONFIG_SSL_STORE_FILE_TYPE = {"JKS", "PKCS12", "PEM"};
Expand Down
8 changes: 8 additions & 0 deletions ...ava/com/gotocompany/dagger/core/source/config/adapter/DaggerSASLMechanismAdaptorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ public void shouldAcceptConfiguredValue() throws IOException {
assertEquals("SCRAM-SHA-512", saslMechanism);
}

@Test
public void shouldAcceptOauthbearer() throws IOException {
when(jsonReader.nextString()).thenReturn("OAUTHBEARER");
DaggerSASLMechanismAdaptor daggerSASLMechanismAdaptor = new DaggerSASLMechanismAdaptor();
String saslMechanism = daggerSASLMechanismAdaptor.read(jsonReader);
assertEquals("OAUTHBEARER", saslMechanism);
}

@Test
public void shouldNotAcceptConfiguredValue() throws IOException {
when(jsonReader.nextString()).thenReturn("SCRAMSHA512");
Expand Down
Loading