fix: allow onAnimate to trigger even when snapping to the same snap index #2504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the react-native-bottom-sheet behavior by adding two key enhancements:
Trigger onAnimate even when snapping to the same index
Previously, onAnimate only fired when the sheet snapped to a new index.
Now, with the new enableSameSnapIndexOnAnimate prop, onAnimate is called even if the target index is the same as the current index.
This allows developers to respond to repeated snaps to the same position, improving flexibility for UI updates or callbacks.
Usage Example:
<BottomSheet
enableSameSnapIndexOnAnimate={true}
onAnimate={(fromIndex, toIndex, fromPosition) => {
if (fromPosition < -40) {
console.log("Over-drag detected, refreshing!");
handleRefresh();
}
}}
/>
Benefits:
More consistent onAnimate behavior.