Fix Playwright workflow to fetch base branch for PR comparison #640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Playwright workflow in
.github/workflows/playwright.ymlfails to detect modified projects in pull request contexts, causing thesamples/find-changes.shscript to return empty results and skip running tests on changed samples.Root Cause: The workflow attempts to compare changes against
origin/${{ github.base_ref }}(e.g.,origin/main), but GitHub Actionscheckout@v4only fetches the current branch (PR branch) by default. Whenfind-changes.shtries to run:git diff --name-only --diff-filter=AM origin/main HEAD -- "samples/"It fails with:
Solution
Add a step after
actions/checkout@v4to explicitly fetch the base branch for PR events:This step:
pull_requestevents (notpushevents)origin/mainreference exists locally for comparisonTesting
Impact
This fix ensures that PR workflows properly detect modified projects, allowing Playwright tests to run on the correct samples rather than being skipped due to empty change detection results.
This pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.