Skip to content

fix: S2A - skip S2A on platforms where netty-tcnative is not available #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: S2A - skip S2A on platforms where netty-tcnative is not available #3802

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecc1802
Skip S2A on platforms where netty-tcnative is not available
rmehta19 May 19, 2025
58e1af5
format
rmehta19 Jun 10, 2025
628fe31
format
rmehta19 Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions gax-java/gax/src/main/java/com/google/api/gax/rpc/EndpointContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,16 @@ private String determineEndpoint() throws IOException {
/** Determine if S2A can be used */
@VisibleForTesting
boolean shouldUseS2A() {
// If running on windows or macos intel, skip S2A. S2A has runtime
// dependency on netty-tcnative which is dropping support on these platforms.
// https://github.com/netty/netty-tcnative/issues/898
// https://github.com/netty/netty-tcnative/issues/897
if (System.getProperty("os.name").contains("Windows")
|| (System.getProperty("os.name").contains("OS X")
&& System.getProperty("os.arch").contains("x86_64"))) {
return false;
}

// If mTLS endpoint is not available, skip S2A
if (Strings.isNullOrEmpty(mtlsEndpoint())) {
return false;
Expand Down
Loading