Skip to content
This repository was archived by the owner on Oct 14, 2025. It is now read-only.

Conversation

plusky
Copy link

@plusky plusky commented May 16, 2016

When packaging for distribution (such as openSUSE), distributions we want to specify CFLAGS/LDFLAGS and in some cases compiler as well.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Makefile Outdated
# Zopfli binary
zopfli:
$(CC) $(ZOPFLILIB_SRC) $(ZOPFLIBIN_SRC) $(CFLAGS) -o zopfli
$(CC) $(ZOPFLILIB_SRC) $(ZOPFLIBIN_SRC) $(CFLAGS) $(LDFLAFS) -o zopfli $(LIBS)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo :)

@googlebot
Copy link

CLAs look good, thanks!

@CounterPillow
Copy link

Did you see #92?

@plusky
Copy link
Author

plusky commented May 17, 2016

Did you see #92?

Yes I did see it, it does not allow specifying compiler, and instead of := there is some funky "override CFLAGS" used. Last but not leas, current makefile does not handle LDFLAGS correctly, which is also fixed here.

@scop
Copy link
Contributor

scop commented Sep 2, 2021

Seems this was at least partially taken care of in 4a35d30

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants